Yair Zaslavsky has posted comments on this change.
Change subject: utils: ssh: move to member '_' convention
......................................................................
Patch Set 2: (1 inline comment)
IMHO, its bad our code has several code conventions (and I worked with all
kinds of them in different companies).
There's no perfect coding convention, most Java developers (this is a
Java-based open source project, at least at engine-side) are used to some
convention - IMHO, if we should fix convention it should be towards what most
Java developers are used to.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
Line 6: * Soft constraint byte array output stream.
Line 7: */
Line 8: public class ConstraintByteArrayOutputStream extends
ByteArrayOutputStream {
Line 9: private int _max;
Line 10: private boolean _truncated = false;
Any reason why you moved to _ ? :)
Please don't :)
Line 11:
Line 12: /**
Line 13: * Constructor.
Line 14: *
--
To view, visit http://gerrit.ovirt.org/9171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
