Shireesh Anjal has posted comments on this change. Change subject: bootstrap: remove VdsInstallerSSH::getServerKeyFingerprint() ......................................................................
Patch Set 2: Current implementation has single implementation of the method getServerKeyFingerprint() called from two different places. This patch creates two exact copies on getServerKeyFingerprint() at two different places. I'm not sure how one could argue or accept that this does not change the current implementation. The function getServerKeyFingerprint() itself is not specific to gluster as such. It should go to a generic common place that is not specific to gluster. I guess I have every right to express my opinion on the patch. You have, of course, every right to ignore/override my concern and get it approved and merged. More so when you're convinced that the concern is incorrect :) -- To view, visit http://gerrit.ovirt.org/9160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
