Einav Cohen has posted comments on this change. Change subject: bootstrap: host add: differentiate between authentication error and other errors ......................................................................
Patch Set 3: Looks good to me, but someone else must approve - reviewed messages only (AppErrors.properties/AppErrors.java) - not critical: I think that the double "cannot" within the messages can be changed to something like one of the following: - "cannot [action] [type]. Connecting to the Host via SSH has failed. ..." - "cannot [action] [type] due to failure in connecting to the Host via SSH. ..." (just sounds better, IMO) - giving "+1" only, as the remaining files in this patch need to be reviewed by an engine-core maintainer. -- To view, visit http://gerrit.ovirt.org/9178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d87fdd0c8942ec39632bd4562694bd5d027cbd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
