Omer Frenkel has posted comments on this change.
Change subject: core: libosinfo - introduce libosinfo service
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CpuArch.java
Line 9: ALL(1),
Line 10: i386(2),
Line 11: i586(3),
Line 12: i686(4),
Line 13: X86_64(5);
why to use ids for new enum? isn't it better to use the name?
Line 14:
Line 15: private final int id;
Line 16:
Line 17: private static Map<Integer, CpuArch> map = new HashMap<Integer,
CpuArch>(values().length);
....................................................
File
backend/manager/modules/services/libosinfo/interface/src/main/java/org/ovirt/engine/core/services/libosinfo/LibosinfoServiceXmlImpl.java
Line 64: }
Line 65: }
Line 66: }
Line 67:
Line 68: } catch (JAXBException e) {
"maybe write some warning to the log with what happened, if you think its not
interesting / relevant then even in debug, may be useful sometime"
Line 69: // failed to load files or unmarshal objects from them
Line 70: // the inner map is empty - ignore...
Line 71: }
Line 72:
--
To view, visit http://gerrit.ovirt.org/8472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I663dbae36d583ca4c524b2957a9a695e44207975
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
