Shireesh Anjal has posted comments on this change.
Change subject: gluster: replace VdsInstallerSSH: with the SSHDialog
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
Line 19: String serverName = "localhost";
Line 20: String fingerPrint =
"b5:ad:16:19:06:9f:b3:41:69:eb:1c:42:1d:12:b5:31";
Line 21:
Line 22: @BeforeClass
Line 23: public static void init() {
Yes, it is an inferior solution because you are not mocking EngineSSHDialog.
Better solution is:
- Write a test case for EngineSSHDialog and test all it's methods in it. Note
that here you don't have to chase down all 'indirectly used' configurations -
only the ones used by EngineSSHDialog.
- Mock EngineSSHDialog in GetServerSSHKeyFingerprintQueryTest. No need to mock
any configuration here.
Line 24: IConfigUtilsInterface confInstance = new
DefaultValuesConfigUtil();
Line 25: Config.setConfigUtils(confInstance);
Line 26: }
Line 27:
--
To view, visit http://gerrit.ovirt.org/9160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48e02991635a5eb2c954da392cdd5f68219120b3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
