Douglas Schilling Landgraf has posted comments on this change.
Change subject: bootstrap: allow distinguish error from non error messages
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
-1 since I have question
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java
Line 87: }
Line 88: AuditLogableBase logable = new AuditLogableBase(_vdsId);
Line 89: logable.AddCustomValue("Message",
StringUtils.stripEnd(sb.toString(), " "));
Line 90: AuditLogDirector.log(logable, logType);
Line 91: return error;
Do we need two return error? I think that the below return error is enough for
the both cases. isn't?
Line 92: }
Line 93:
Line 94: return error;
Line 95: }
--
To view, visit http://gerrit.ovirt.org/9161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
