Yair Zaslavsky has posted comments on this change.
Change subject: engine: Gluster Volume Geo-replication Start
......................................................................
Patch Set 7: (3 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_01_1450_add_gluster_georeplication_table.sql
Line 22: end;
Line 23: end if;
Line 24:
Line 25: -- Create partial index for fetching Gluster Volume Georeplications
Line 26: DROP INDEX if exists IDX_gluster_georeplication_volume_id;
No need to perform drop index if exists, DB scripts are no longer reentrant
Line 27: CREATE INDEX IDX_gluster_georeplication_volume_id ON
gluster_volumes(id);
Line 28:
Line 29: END; $procedure$
Line 30: LANGUAGE plpgsql;
Line 23: end if;
Line 24:
Line 25: -- Create partial index for fetching Gluster Volume Georeplications
Line 26: DROP INDEX if exists IDX_gluster_georeplication_volume_id;
Line 27: CREATE INDEX IDX_gluster_georeplication_volume_id ON
gluster_volumes(id);
I see in DAO we also get by server id. any reason why not to index server_id as
well?
Line 28:
Line 29: END; $procedure$
Line 30: LANGUAGE plpgsql;
Line 31:
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoreplicationDaoTest.java
Line 14: /**
Line 15: * Tests for Gluster Georeplication DAO
Line 16: */
Line 17: public class GlusterGeoreplicationDaoTest extends BaseDAOTestCase {
Line 18: private static final Guid VOLUME_ID = new
Guid("0c3f45f6-3fe9-4b35-a30c-be0d1a835ea8");
Please look at FixturesTool and set constants there (at least for the UUIDs)
Line 19: private static final Guid SERVER_ID = new
Guid("afce7a39-8e8c-4819-ba9c-796d316592e6");
Line 20: private static final String REMOTE_SERVER_HOSTNAME =
"test-server-1";
Line 21: private static final String SSH_KEY_FINGERPRINT =
"04:d0:b2:43:2c:f7:ad:d5:61:c3:f2:f5:19:1a:d6:4b";
Line 22: private static final String REMOTE_SERVER_USER_NAME = "root";
--
To view, visit http://gerrit.ovirt.org/8892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63260b02a8bd5125b27498355e5daf9b29cbe00
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
