Vered Volansky has posted comments on this change. Change subject: core: Fix error message for locked disks ......................................................................
Patch Set 11: (1 inline comment) Sharad: Grammatically a list (after colon) may contain only one item. So I'm sure the current version is grammatically correct. I'm not sure about the grammatical correctness of your suggestion, and I suspect there might be a problem with the "be" inflection. I'd rather stay with what I know is correct. .................................................... Commit Message Line 8: Line 9: This fix is related to bug Bug-Url: https://bugzilla.redhat.com/865551 , Line 10: though not specifically mentioned there. Line 11: It fixes an error message displayed when trying to run a VM while one or Line 12: more of its disks are locked. Previous message showed multiple disks Done Line 13: locked message while indicating there is only one locked disk, and disks_aliases was not Line 14: substituted with actual disks aliases. The same issue occurred with Line 15: MoveOrCopyDiskCommand. There were two separate messages for the one Line 16: locked disk and multiple locked disks. Now one message replaces the -- To view, visit http://gerrit.ovirt.org/8693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
