Allon Mureinik has posted comments on this change.
Change subject: core: Fix Moving Disk message (#856082)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
no test?
....................................................
Commit Message
Line 11:
Line 12: Added to ImageOperation enum an action data member in the
Line 13: progressive form (moving, copying), while the message now only
Line 14: uses {$Action}, which is extracted from the ImageOperation enum (the
newly
Line 15: added action).
I'd rephrase this message in active tense, it's a bit hard to read.
Line 16:
Line 17: Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3
Line 18: Bug-Url: https://bugzilla.redhat.com/856082
--
To view, visit http://gerrit.ovirt.org/9303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches