Mike Kolesnik has posted comments on this change. Change subject: engine: Change Error Messages (#871864) ......................................................................
Patch Set 2: Looks good to me, approved Since they both inherit from NetworkCommon, you could consider extracting VLAN validation logic (plus other shared logic) out of the inheriting canDoActions to common commands. -- To view, visit http://gerrit.ovirt.org/9311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I095ecde03174fabafbb556ffc82ba22a8b443a36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
