Daniel Erez has posted comments on this change.
Change subject: webadmin: add advanced parameters to VM Interface dialog
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml
Line 32: addStyleNames="isTemplatePrivateEditor"
/>
Line 33: <g:Label
ui:field="enableManualMacCheckboxLabel" />
Line 34: </g:HorizontalPanel>
Line 35: <e:EntityModelTextBoxEditor ui:field="MACEditor" />
Line 36: <g:Label ui:field="macExample"
addStyleNames="{style.macExample}" text="{constants.exampleInterfacePopup}
00:14:4a:23:67:55" />
Please remove TWS on rebase
Line 37: <d:AdvancedParametersExpander ui:field="expander"
addStyleNames="{style.expander}"/>
Line 38: <g:FlowPanel ui:field="expanderContent"
addStyleNames="{style.expanderContent}">
Line 39: <e:EntityModelCheckBoxEditor
ui:field="portMirroringEditor" />
Line 40: <e:EntityModelCheckBoxEditor
ui:field="activateCheckBox"/>
--
To view, visit http://gerrit.ovirt.org/9310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
