Allon Mureinik has posted comments on this change.
Change subject: core: OvfReader cleanup - document empty blocks
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 382:
Line 383: readGeneralData(content);
Line 384: }
Line 385:
Line 386: protected void readSnapshotsSection(XmlNode section) {
there is an @Override annotation in the extending class.
Are you perhaps getting confused with @SuppressWaring ("unused") which could be
neat here?
Line 387: // The snapshot section only has meaning for VMs, and is
overridden in OvfVmReader.
Line 388: }
Line 389:
Line 390: protected abstract void readGeneralData(XmlNode content);
....................................................
Commit Message
Line 6:
Line 7: core: OvfReader cleanup - document empty blocks
Line 8:
Line 9: Documented the empty implementation of buildNetworks() and
Line 10: readSnapshostsSection(String) to avoid warnings by code analysis tools
Done
Line 11: (e.g., Eclipse IDE's built it inspection feature).
Line 12:
Line 13: Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd
Line 14: Relates-To: https://bugzilla.redhat.com/72506
--
To view, visit http://gerrit.ovirt.org/9304
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
