Juan Hernandez has posted comments on this change. Change subject: packaging: Don't require Maven packages for build ......................................................................
Patch Set 1: > Want do you mean without GWT? how does it actually work? I mean that we don't build webadmin or userportal because to compile them we need the GWT compiler, and the GWT compiler is not included in Fedora. > Why can't we add the GWT files as Source entries, and just use it as-is? You can of course add those source files, but that doesn't make sense in my opinion, if you want GWT in Fedora then what you should do is package it for Fedora. In addition the GWT sources themselves are useless, they have to be compiled, and the result has to work correctly, because what we need is the binaries of the GWT compiler in order to be able to compile the GWT applications (webadmin and user portal). And that is the challenge: building a working GWT compiler using only the packages that are already available in Fedora. > I will be glad to help once I get the next task done (rewrite the config > values stuff and the messages). There is work ongoing to package GWT for Fedora, leaded by Andy Grimm as part of the project to include Eucalyptus in Fedora (see [1]). I suggest you contact him and offer your help. > When I looked at this spec in the past I did not understand (and still don't) > what is merged and what is not, how far are we in term of upstream and fedora > ready. The Fedora .spec is different to the upstream .spec in that it doesn't build the GWT applications and it it uses mvn-rpmbuild instead of mvn, those are the main differences. [1] https://fedoraproject.org/wiki/Eucalyptus -- To view, visit http://gerrit.ovirt.org/9400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c924ecc53df483976b2bc5ea1777249c120f0ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
