Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Fixing localization issues in Volume dialog ......................................................................
webadmin: Fixing localization issues in Volume dialog Button texts were not localized in Create Volume and Add Bricks dilogs. This is fixed now. Change-Id: I98696b78b1d48cdb0d5b99e1a62741313580b4b9 Signed-off-by: Kanagaraj M <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 3 files changed, 26 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/9403/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java index 87363ee..125c6f0 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java @@ -58,13 +58,16 @@ setAddBrickCommand(new UICommand("AddBrick", this)); //$NON-NLS-1$ setRemoveBricksCommand(new UICommand("RemoveBricks", this)); //$NON-NLS-1$ setRemoveAllBricksCommand(new UICommand("RemoveAllBricks", this)); //$NON-NLS-1$ - // getAddBrickCommand().setIsExecutionAllowed(false); - // getClearBrickDetailsCommand().setIsExecutionAllowed(false); + getAddBrickCommand().setTitle(ConstantsManager.getInstance().getConstants().addBricksButtonLabel()); + getRemoveBricksCommand().setTitle(ConstantsManager.getInstance().getConstants().removeBricksButtonLabel()); + getRemoveAllBricksCommand().setTitle(ConstantsManager.getInstance().getConstants().removeAllBricksButtonLabel()); getRemoveBricksCommand().setIsExecutionAllowed(false); getRemoveAllBricksCommand().setIsExecutionAllowed(false); setMoveBricksUpCommand(new UICommand("MoveBricksUp", this)); //$NON-NLS-1$ setMoveBricksDownCommand(new UICommand("MoveBricksDown", this)); //$NON-NLS-1$ + getMoveBricksUpCommand().setTitle(ConstantsManager.getInstance().getConstants().moveBricksUpButtonLabel()); + getMoveBricksDownCommand().setTitle(ConstantsManager.getInstance().getConstants().moveBricksDownButtonLabel()); getMoveBricksUpCommand().setIsExecutionAllowed(false); getMoveBricksDownCommand().setIsExecutionAllowed(false); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java index 56b3e31..5111b8f 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java @@ -74,6 +74,7 @@ setAddBricksCommand(new UICommand("AddBricks", this)); //$NON-NLS-1$ getAddBricksCommand().setIsExecutionAllowed(false); + getAddBricksCommand().setTitle(ConstantsManager.getInstance().getConstants().addBricksVolume()); setDataCenter(new ListModel()); getDataCenter().getSelectedItemChangedEvent().addListener(new IEventListener() { diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java index 8d22841..807e25f 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java @@ -2,6 +2,8 @@ + + public interface Constants extends com.google.gwt.i18n.client.Constants { @DefaultStringValue("OK") @@ -1292,6 +1294,24 @@ String addBricksVolume(); @DefaultStringValue("Add") + String addBricksButtonLabel(); + + @DefaultStringValue("Remove") + String removeBricksButtonLabel(); + + @DefaultStringValue("Clear") + String clearBricksButtonLabel(); + + @DefaultStringValue("Remove All") + String removeAllBricksButtonLabel(); + + @DefaultStringValue("Move Up") + String moveBricksUpButtonLabel(); + + @DefaultStringValue("Move Down") + String moveBricksDownButtonLabel(); + + @DefaultStringValue("Add") String AddVolume(); @DefaultStringValue("Edit") -- To view, visit http://gerrit.ovirt.org/9403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I98696b78b1d48cdb0d5b99e1a62741313580b4b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
