Allon Mureinik has posted comments on this change. Change subject: core: remove unused private method from AddVdsCommand ......................................................................
Patch Set 2: On retrospect, this patch is partial. If you remove org.ovirt.engine.core.bll.AddVdsCommand.validateHostUniqueNameAndAddress(VdsStatic), you should also remove the following functions that are only used by it: 1. org.ovirt.engine.core.bll.VdsHandler.isVdsExist(VdsStatic, ArrayList<String>) 2. org.ovirt.engine.core.bll.VdsHandler.isVdsExistForPendingOvirt(VdsStatic, ArrayList<String>, Guid) -- To view, visit http://gerrit.ovirt.org/9388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I849faae971693c05be218309bc1f8dd76aafd315 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
