Alon Bar-Lev has posted comments on this change. Change subject: core: cleanup InstallVdsCommand II ......................................................................
Patch Set 1: BTW: I don't see the value of spanning out this particular code, better is to split this function into two at the node/host split. However, this is not enough, as the proper fix would be to separate the node upgrade command from the host install command, as these are two separate commands at single command. The last bootstrap patch series just exposed it. So I tend not to add more refactoring here, but recommend in splitting commands. -- To view, visit http://gerrit.ovirt.org/9407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id83a096fee287caab282fcafa833fcfec7707823 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
