Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: make approve command respect installation failure ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 7: bootstrap: make approve command respect installation failure Line 8: Line 9: Current implementation assumes success at all results, which is invalid. Line 10: Line 11: Do not use parent member if there is a method to access it. Are you sure? these are related... "badly written command"... Line 12: Line 13: Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f -- To view, visit http://gerrit.ovirt.org/9443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
