Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
Something is wrong with this patch.
....................................................
File GinaSSO/GinaDlg.cpp
Line 325:
Line 326: // Redirected WlxDialogBoxParam() function.
Line 327: int
Line 328: WINAPI
Line 329: yWlxDialogBoxParam(
How this related to this patch?
Line 330: HANDLE hWlx,
Line 331: HANDLE hInst,
Line 332: LPWSTR lpszTemplate,
Line 333: HWND hwndOwner,
....................................................
File GinaSSO/GinaSSO.sln
Line 1:
Line 2: icrosoft Visual Studio Solution File, Format Version 10.00
??? something is wrong in this patch.
Line 3: # Visual Studio 2008
Line 4: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "GinaSSO",
"GinaSSO.vcproj", "{87EADA77-9319-446D-9BC3-419B9020B41D}"
Line 5: EndProject
Line 6: Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "SSOInstallLogic",
"..\SSOInstallLogic\SSOInstallLogic.vcproj",
"{E2C275FC-6B2C-4072-8DD6-3EC1DF20839F}"
....................................................
File .gitignore
Line 22: depcomp
Line 23: install-sh
Line 24: libtool
Line 25: ltmain.sh
Line 26: akefile
?????
Line 27: akefile.in
Line 28: missing
Line 23: install-sh
Line 24: libtool
Line 25: ltmain.sh
Line 26: akefile
Line 27: akefile.in
???
Line 28: missing
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
