Eli Mesika has posted comments on this change.
Change subject: engine: engine-config cleanup all 2.2 keys from db
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 613: select fn_db_delete_config_by_name('LocalStorageEnabled');
Line 614: select fn_db_delete_config_by_name('SupportCustomProperties');
Line 615: select fn_db_delete_config_by_name('SupportGetDevicesVisibility');
Line 616: select fn_db_delete_config_by_name('SupportStorageFormat');
Line 617: select fn_db_delete_config_by_name('UseRtl8139_pv');
sure
lets assume that you are removing IsNeedSupportForOldVgAPI with
select fn_db_delete_config_by_name('IsNeedSupportForOldVgAPI');
Now , lets also assume that this key is back from som reason in future version
> 3.1
So, you will add it again in the *add* section for that future release, but ,
the call in the *delete* section that you have added will remove it , so , it
is error prone.
>From that reason I prefer
select fn_db_delete_config_for_version('2.2,3.0,3.1');
because, now , that key can be back and everything works perfect.
Line 618:
------------------------------------------------------------------------------------
Line 619: -- Split config section
Line 620: -- The purpose of this section is to treat config option that was once
Line 621: -- general, and should now be version-specific.
--
To view, visit http://gerrit.ovirt.org/9492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdfed4efa2c4d1f52189943fd1dd38ea0c3cbb0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
