liron aravot has posted comments on this change.

Change subject: core:WIP: introducing OvfAutoUpdate
......................................................................


Patch Set 10: (2 inline comments)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDbFacadeImpl.java
Line 17:     }
Line 18: 
Line 19:     @Override
Line 20:     public Long getOvfGeneration(Guid id) {
Line 21:         return getCallsHandler().executeRead("GetOvfGeneration",
will be replaced with single instance mapper, implemented temporary like this 
as a further related refactoring required.
Line 22:                 new ParameterizedRowMapper<Long>() {
Line 23:                     @Override
Line 24:                     public Long mapRow(ResultSet rs, int rowNum) 
throws SQLException {
Line 25:                         return rs.getLong(1);


....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
Line 158:     }
Line 159: 
Line 160:     @Override
Line 161:     public Long getDbGeneration(Guid id) {
Line 162:         return getCallsHandler().executeRead("GetDbGeneration",
will be replaced with single instance mapper, implemented temporary like this 
as a further related refactoring required.
Line 163:                 new ParameterizedRowMapper<Long>() {
Line 164:                     @Override
Line 165:                     public Long mapRow(ResultSet rs, int rowNum) 
throws SQLException {
Line 166:                         return rs.getLong(1);


--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to