Juan Hernandez has posted comments on this change.
Change subject: WIP: working CDI solution for backend
......................................................................
Patch Set 3: (2 inline comments)
This is a really nice step in the right direction. Hope you continue with it.
....................................................
File backend/manager/modules/bll/pom.xml
Line 212: <dependency>
Line 213: <groupId>org.jboss.solder</groupId>
Line 214: <artifactId>solder-impl</artifactId>
Line 215: <version>3.1.1.Final</version>
Line 216: </dependency>
Do we really need these two dependencies? We should need only the cdi-api as
the implementation should be provided by the environment (by JBoss AS).
Line 217:
Line 218: </dependencies>
Line 219:
Line 220: <build>
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 107: }
Line 108:
Line 109: @Produces
Line 110: public DbFacade getDbFacade() {
Line 111: return DbFacade.getInstance();
Wouldn't make more sense to make DbFacade a @ApplicationScoped?
Line 112: }
Line 113:
Line 114: private void InitHandlers() {
Line 115: mTagsHandler = HandlersFactory.createTagsHandler();
--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
