Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup - unwrap else blcoks
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 247:
image.setstorage_pool_id(getParameters().getStoragePoolId());
Line 248: // we put the source domain id in order that
copy will
Line 249: // work properly.
Line 250: // we fix it to DestDomainId in
Line 251: // MoveOrCopyAllImageGroups();
That a behavior change I don't want to introduce right now.
This image is passed on to a MoveOrCopy command, and g-d only knows what gets
serialized there and how
Line 252: image.setstorage_ids(new
ArrayList<Guid>(Arrays.asList(getParameters().getSourceDomainId())));
Line 253: }
Line 254: if (retVal) {
Line 255: Map<Guid, List<DiskImage>> images =
getImagesLeaf(getVm().getImages());
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-28 10:31:20 +0200
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2012-12-02 09:32:49 +0200
Line 6:
Line 7: core: ImportVm cleanup - unwrap else blcoks
Done
Line 8:
Line 9: Unwrapped useless else block when execution does not continue after the
Line 10: if block (e.g., the if block has a return or break statement).
Line 11:
--
To view, visit http://gerrit.ovirt.org/9611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice993e9c0a1ce8275a43b8277ddf9574590ee290
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
