Daniel Erez has uploaded a new change for review. Change subject: webadmin: clear search button resets search incorrectly ......................................................................
webadmin: clear search button resets search incorrectly Clear search button sets 'searchString' to null (instead of an empty string) when 'hasSearchStringPrefix' is true. Some affected scenarios: * Selecting an item from system tree -> clear search -> create a bookmark: bookmark's search string ends with "null" (underlying reason - CommonModel -> getEffectiveSearchString: getSearchStringPrefix() + getSearchString()). * Selecting disks main tab -> clear search -> create a bookmark: same as above. * Selecting disks main tab -> clear search: blank list - since the 'effectiveSearchString' ends with null. Change-Id: I2dfd1f51fac032df4593916c09944552a349b709 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/9639/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java index ae966fe..b488452 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java @@ -689,7 +689,7 @@ private void ClearSearchString() { - setSearchString(getHasSearchStringPrefix() ? null : getSelectedItem().getDefaultSearchString(), false); + setSearchString(getHasSearchStringPrefix() ? "" : getSelectedItem().getDefaultSearchString(), false); //$NON-NLS-1$ getSearchCommand().Execute(); } -- To view, visit http://gerrit.ovirt.org/9639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2dfd1f51fac032df4593916c09944552a349b709 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
