Eli Mesika has posted comments on this change.
Change subject: core: VmPropertiesUtils should be initialized via StartupBean
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 61: log.infoFormat("Init VM Custom Properties utilities: {0}",
new Date());
Line 62: VmPropertiesUtils.getInstance().init();
Line 63: } catch (InitializationException e) {
Line 64: log.errorFormat("Initialization failed. Exception message
is {0} ",e.getMessage());
Line 65: log.debug("Initialization failed ",e);
Why adding also DEBUG ???
In other places we are printing just an ERROR ....
I think that should be replaced with a ERROR that prints the whole Exception
object
Line 66: throw new RuntimeException(e);
Line 67: }
Line 68: }
Line 69:
--
To view, visit http://gerrit.ovirt.org/9430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If25ef37b0d9ff79737e7efe8283372aca70b0dcb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
