Arik Hadas has posted comments on this change.
Change subject: userportal,webadmin: switch tab with space key
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
Line 48: tab.addKeyUpHandler(new KeyUpHandler() {
Line 49: @Override
Line 50: public void onKeyUp(KeyUpEvent event) {
Line 51: // if space key was pressed
Line 52: if (32 == event.getNativeKeyCode()) {
there is no key code constant for space key - I already check it
(http://google-web-toolkit.googlecode.com/svn/javadoc/1.6/com/google/gwt/event/dom/client/KeyCodes.html)
It seems that the right way to implement it is to change the tab header from
being a wrapped label to button and then to catch its click events - but the
current implementation required less changes..
what do you think?
Line 53: switchTab(tab);
Line 54: }
Line 55: }
Line 56: });
--
To view, visit http://gerrit.ovirt.org/9637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
