Moti Asayag has posted comments on this change.
Change subject: core: Cleanup on notification service resource closing
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Basically +2 for all of the changes except the tws.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java
Line 11: * JDK7 compliance as Connection, ResultSet and Statement extend
Line 12: * AutoClosable
Line 13: */
Line 14: public class DbUtils {
Line 15:
this is going to break the checkstyle build...
Line 16: public static void closeQuietly(ResultSet result) {
Line 17: if (result != null) {
Line 18: try {
Line 19: result.close();
Line 41: }
Line 42:
Line 43: public static void closeQuietly(ResultSet resultSet, Connection
connection) {
Line 44: closeQuietly(resultSet, null, connection);
Line 45: }
same.
Line 46:
Line 47: public static void closeQuietly(Statement statement, Connection
connection) {
Line 48: closeQuietly(null,statement, connection);
Line 49: }
--
To view, visit http://gerrit.ovirt.org/9740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c4e156123
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
