Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVm cleanup: DAO accessors
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 327: protected StoragePoolIsoMapDAO getStoragePoolIsoMapDAO() {
Line 328: return getDbFacade().getStoragePoolIsoMapDao();
Line 329: }
Line 330:
Line 331: protected BaseDiskDao getBaseDiskDao() {
Better to switch Dao to be upper case here, to keep as much unify convention as
possible.
Line 332: return getDbFacade().getBaseDiskDao();
Line 333: }
Line 334:
Line 335: protected ImageDao getImageDao() {
Line 331: protected BaseDiskDao getBaseDiskDao() {
Line 332: return getDbFacade().getBaseDiskDao();
Line 333: }
Line 334:
Line 335: protected ImageDao getImageDao() {
Same here please switch getImageDao to getImageDAO
Line 336: return getDbFacade().getImageDao();
Line 337: }
Line 338:
Line 339: protected DiskImageDAO getDiskImageDao() {
Line 343: protected DiskImageDynamicDAO getDiskImageDynamicDAO() {
Line 344: return getDbFacade().getDiskImageDynamicDao();
Line 345: }
Line 346:
Line 347: protected SnapshotDao getSnapshotDao() {
Same here
Line 348: return getDbFacade().getSnapshotDao();
Line 349: }
Line 350:
Line 351: protected ImageStorageDomainMapDao getImageStorageDomainMapDao() {
....................................................
Commit Message
Line 8:
Line 9: Cleaned up DAO access in ImportVmCommand.
Line 10:
Line 11: Replaced all instances of DbFacade.getInstance().getXXDao() with
Line 12: protected getXXDao() methods, and moved available methods to their
/getXXDao/getXXDAO
Line 13: correct place in the hierarchy.
Line 14:
Line 15: Change-Id: I331be144f94df2b7527e9b36289347109d4b266d
--
To view, visit http://gerrit.ovirt.org/9614
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I331be144f94df2b7527e9b36289347109d4b266d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
