Liron Aravot has posted comments on this change.
Change subject: core: ImportVm cleanup: iterate maps values()
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 601: diskGuidList.add(disk.getId());
Line 602: imageGuidList.add(disk.getImageId());
Line 603: if (getParameters().isImportAsNewEntity()) {
Line 604: disk.setId(Guid.NewGuid());
Line 605: disk.setImageId(Guid.NewGuid());
the loop before iterated all over the disks besides the last one, now you are
iterating all over the disks, is this intentional?
Line 606: for (DiskImage currDisk : diskList) {
Line 607: currDisk.setId(disk.getId());
Line 608: }
Line 609: }
--
To view, visit http://gerrit.ovirt.org/9616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
