Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: createVm return
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
Line 57:
Line 58: protected ImportVmParameters createParameters() {
Line 59: final VM v = createVM();
Line 60: v.setVmName("testVm");
Line 61: return new ImportVmParameters(v, Guid.NewGuid(),
Guid.NewGuid(), Guid.NewGuid(), Guid.NewGuid());
I really hate creating variables just to return them a line later, and I must
say I disagree about making it harder to debug.
Let's see what other comments come in?
Line 62: }
Line 63:
Line 64: protected VM createVM() {
Line 65: final VM v = new VM();
--
To view, visit http://gerrit.ovirt.org/9793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec82913fbb116544293d2aeabbd86d00d08374c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
