Allon Mureinik has posted comments on this change. Change subject: core: ImportVm test cleanup: remove spring ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java Line 109: spy(new ImportVmCommand(parameters)); Line 110: Set<ConstraintViolation<ImportVmParameters>> validate = Line 111: ValidationUtils.getValidator().validate(parameters, Line 112: command.getValidationGroups().toArray(new Class<?>[0])); Line 113: assertEquals(validate.isEmpty(), !isImportAsNewEntity); Agree. Not we just need the JUnit guys to implement it, and I'll rebase on top of it :-) Line 114: } Line 115: Line 116: /** Line 117: * Checking that other fields in vmStatic aren't get validated in Import or -- To view, visit http://gerrit.ovirt.org/9617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e7593ea28751cd6c4c50a54ec0bdf46174107f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
