Liron Aravot has posted comments on this change.
Change subject: core: Unit test ImagesHandler.getSuggestedAlias
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
Line 36: }
Line 37:
Line 38: @Test
Line 39: public void testGetSuggestedDiskAliasNotNullAliasDisk() {
Line 40: disk.setDiskAlias("someAlias");
Sorry for not mentioning it in the last patchset ..but I don't really like this
test, I think that it's more correct to use == rather then equals here which
will return us true in case of new string with same value which we want to
avoid to even create.
Line 41: assertEquals("existing disk alias was wrongfully overwritten",
Line 42: disk.getDiskAlias(),
Line 43: ImagesHandler.getSuggestedDiskAlias(disk, prefix, 1));
Line 44: }
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
