Daniel Erez has posted comments on this change.
Change subject: restapi: Added "scan" to disks resource to import clones
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportImageCommand.java
Line 24: @Override
Line 25: protected void executeCommand() {
Line 26: final DiskImage newDiskImage = getParameters().getDiskImage();
Line 27: if (newDiskImage != null) {
Line 28: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Why a new transaction is needed here?
Line 29: @Override
Line 30: public Void runInTransaction() {
Line 31: addDiskImageToDb(newDiskImage,
getCompensationContext());
Line 32:
getReturnValue().setActionReturnValue(newDiskImage.getId());
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportImageParameters.java
Line 6: public class ImportImageParameters extends ImagesActionsParametersBase {
Line 7:
Line 8: /**
Line 9: *
Line 10: */
redundant comment..
Line 11: private static final long serialVersionUID = -2354567059991414220L;
Line 12:
Line 13: private DiskImage diskImage;
Line 14:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 106: RemoveSnapshot(210, ActionGroup.MANIPULATE_VM_SNAPSHOTS,
QuotaDependency.STORAGE),
Line 107: RemoveImage(211, QuotaDependency.STORAGE),
Line 108: RemoveAllVmImages(212, QuotaDependency.STORAGE),
Line 109: AddImageFromScratch(213, QuotaDependency.STORAGE),
Line 110: ImportImage(214, ActionGroup.CONFIGURE_VM_STORAGE,
QuotaDependency.STORAGE),
Is quota required for importing a disk?
Line 111: RemoveTemplateSnapshot(215, QuotaDependency.STORAGE),
Line 112: RemoveAllVmTemplateImageTemplates(216, QuotaDependency.STORAGE),
Line 113: TryBackToAllSnapshotsOfVm(223,
ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.NONE),
Line 114: RestoreAllSnapshots(224, ActionGroup.MANIPULATE_VM_SNAPSHOTS,
QuotaDependency.STORAGE),
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-30 14:05:14 -0500
Line 4: Commit: Chris Morrissey <[email protected]>
Line 5: CommitDate: 2012-11-30 15:24:46 -0500
Line 6:
Line 7: restapi: Added "scan" to disks resource to import clones
Subject's prefix should be changed to 'core'.
Or ideally, split it to 'core' and 'restapi' patches.
Line 8:
Line 9: I am working on a plugin for NetApp storage systems that will
Line 10: use its cloning capabilities to clone disks outside of oVirt.
Line 11: This new API will allow us to have those disks imported into
--
To view, visit http://gerrit.ovirt.org/9603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6236e563d38ee1a793bd94ff60587f19b3010d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
