Mike Kolesnik has posted comments on this change.

Change subject: engine: Modify Network Assign to Cluster Command permissions
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 82:     AttachNetworkToVdsInterface(150, 
ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE),
Line 83:     DetachNetworkFromVdsInterface(151, 
ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE),
Line 84:     AddBond(152, ActionGroup.CONFIGURE_HOST_NETWORK, 
QuotaDependency.NONE),
Line 85:     RemoveBond(153, ActionGroup.CONFIGURE_HOST_NETWORK, 
QuotaDependency.NONE),
Line 86:     AddNetwork(154, ActionGroup.CREATE_STORAGE_POOL_NETWORK, false, 
QuotaDependency.NONE),
I think this slipped in here by accident?
Line 87:     RemoveNetwork(155, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, 
false, QuotaDependency.NONE),
Line 88:     UpdateNetwork(156, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, 
false, QuotaDependency.NONE),
Line 89:     CommitNetworkChanges(157, ActionGroup.CONFIGURE_HOST_NETWORK, 
QuotaDependency.NONE),
Line 90:     SetupNetworks(158, ActionGroup.CONFIGURE_HOST_NETWORK, 
QuotaDependency.NONE),


--
To view, visit http://gerrit.ovirt.org/9540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to