Mike Kolesnik has posted comments on this change.
Change subject: engine: Extend NetworkDao
......................................................................
Patch Set 7: (1 inline comment)
Please add tests for the filtered method also
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java
Line 62: * Ensures that retrieving a network by name and data center works
as expected.
Line 63: */
Line 64: @Test
Line 65: public void testGetByNameAndDataCenter() {
Line 66: Network result = dao.getByNameAndDataCenter("engine",
datacenter);
"engine" can be extracted to constant
Line 67:
Line 68: assertNotNull(result);
Line 69: assertEquals("engine", result.getname());
Line 70: }
--
To view, visit http://gerrit.ovirt.org/9543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If559aaf1ce824a0271874cf10cff1e42dd4647ba
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
