Michael Kublin has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Reuse a code, make connect parallel.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 201: * performs any connect related operations if needed before
attempting
Line 202: * to connect/refresh pool information.
Line 203: * @param vds
Line 204: * @return
Line 205: */
Maybe it is time to start reuse a code. Look how connect is done at
ActivateStorageDomainCommand. If we have a 30 host the following code will run
forever
Line 206: private boolean connectVdsToNewMaster(VDS vds) {
Line 207: storage_domains masterDomain = getNewMaster(false);
Line 208: if (vds.getId().equals(getVds().getId())
Line 209: ||
StorageHelperDirector.getInstance().getItem(masterDomain.getstorage_type())
--
To view, visit http://gerrit.ovirt.org/9748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3733b732b37f3a687b24f90bfdb1799757434d75
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
