Moti Asayag has posted comments on this change.
Change subject: engine: vmstatic and vmbase cleanup
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
Line 33: private String name = "";
Line 34:
Line 35: @Column(name = "vmt_guid")
Line 36: @Type(type = "guid")
Line 37: private Guid vmtGuid = new Guid();
how about changing the attribute's name to templateId instead?
Line 38:
Line 39: @Column(name = "is_initialized")
Line 40: private boolean initialized;
Line 41:
Line 151: public boolean isFirstRun() {
Line 152: return !isInitialized();
Line 153: }
Line 154:
Line 155: public String getVmName() {
perhaps it is better just "getName()" and setName(String) ?
Also can add implementation for
org.ovirt.engine.core.common.businessentities.Nameable which might be handy
(maybe...)
Line 156: return this.name;
Line 157: }
Line 158:
Line 159: public void setVmName(String value) {
--
To view, visit http://gerrit.ovirt.org/9824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b75b583819587b53cd33124d5536d4e114d3494
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
