Michael Pasternak has posted comments on this change.
Change subject: restapi: generate new JSESSIONID when Authorization header
specified
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java
Line 170:
expect(headers.getRequestHeader(SessionUtils.PREFER_HEADER_FIELD)).andReturn(preferHeaders);
Line 171: }
Line 172: if (credentials != null) {
Line 173:
expect(headers.getRequestHeader(HttpHeaders.AUTHORIZATION)).andReturn(authHeaders);
Line 174:
expect(headers.getRequestHeader(HttpHeaders.AUTHORIZATION)).andReturn(authHeaders);
please remove extra expect for headers and instead add .anyTimes(),
i.e
expect(headers.getRequestHeader(HttpHeaders.AUTHORIZATION)).andReturn(authHeaders).anyTimes();
Line 175: Principal principal = new Principal(USER, SECRET, DOMAIN);
Line 176: expect(authorizer.decode(headers)).andReturn(principal);
Line 177: authHeaders.add(credentials);
Line 178: if (valid) {
--
To view, visit http://gerrit.ovirt.org/9820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id586d3cb143e15a95720b2aeb8a9e4ae62f2b72c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
