Vered Volansky has posted comments on this change.
Change subject: core: ImportVm cleanup: canDoAction_beforeCloneVM
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 173: if (!validator.isDomainExistAndActive(canDoActionMessages)
Line 174: ||
!validator.domainIsValidDestination(canDoActionMessages)) {
Line 175: return false;
Line 176: }
Line 177:
I'd remove this empty line. That'll get you -8 lines too!!
Line 178: domainsMap.put(destGuid, storageDomain);
Line 179: }
Line 180:
Line 181: if (getParameters().isImportAsNewEntity() &&
!getParameters().getCopyCollapse()) {
Line 195: (getParameters().getStoragePoolId(),
getParameters().getSourceDomainId());
Line 196: tempVar.setGetAll(true);
Line 197: VdcQueryReturnValue qretVal =
Line 198:
getBackend().runInternalQuery(VdcQueryType.GetVmsFromExportDomain, tempVar);
Line 199:
redundant empty line or is it just gerrit?
Line 200: if (!qretVal.getSucceeded()) {
Line 201: return false;
Line 202: }
Line 203:
Line 199:
Line 200: if (!qretVal.getSucceeded()) {
Line 201: return false;
Line 202: }
Line 203:
Again?
Line 204: List<VM> vms = (List<VM>) qretVal.getReturnValue();
Line 205: VM vm = LinqUtils.firstOrNull(vms, new Predicate<VM>() {
Line 206: @Override
Line 207: public boolean eval(VM evalVm) {
--
To view, visit http://gerrit.ovirt.org/9621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc6c0916948a1951ff30a4ca25aa113923e0643d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
