Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 262: /**
Line 263: * Load images from Import/Export domain.
Line 264: * @return A {@link List} of {@link VM}s, or <code>null</code> if
the query to the export domain failed.
Line 265: */
Line 266: protected List<VM> getVmsFromExportDomain() {
Because the query add logic to the VDS command - checking the domain's type,
parsing the OVF return value to objects, etc.
Line 267: GetAllFromExportDomainQueryParameters p =
Line 268: new GetAllFromExportDomainQueryParameters
Line 269: (getParameters().getStoragePoolId(),
getParameters().getSourceDomainId());
Line 270: VdcQueryReturnValue qRetVal =
getBackend().runInternalQuery(VdcQueryType.GetVmsFromExportDomain, p);
--
To view, visit http://gerrit.ovirt.org/9626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d711cd8df8c0f8eccfe6b7838c16605829b2f6
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
