Mike Kolesnik has posted comments on this change.
Change subject: engine,webadmin: Remove getNetwork from NetworkView
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
Line 2417: else if (entity instanceof Network)
Line 2418: {
Line 2419: return ((Network) entity).getId();
Line 2420: }
Line 2421: else if (entity instanceof NetworkView)
I think this can be deleted
Line 2422: {
Line 2423: return ((NetworkView) entity).getId();
Line 2424: }
Line 2425: return new Guid();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
Line 193:
Line 194: boolean anyEngine = false;
Line 195: for (Object item : selectedItems)
Line 196: {
Line 197: NetworkView networkView = (NetworkView) item;
Can cast to network instead?
Line 198: if (StringHelper.stringsEqual(networkView.getname(),
ENGINE_NETWORK))
Line 199: {
Line 200: anyEngine = true;
Line 201: break;
--
To view, visit http://gerrit.ovirt.org/9790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27d52f966fb0af0ad53afe0d053d5a01f659ab42
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
