Eli Mesika has posted comments on this change.
Change subject: core: Renamed event_map.java to EventMap.java
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java
Line 39: List<event_notification_methods>
event_notification_methods = (DbFacade.getInstance()
Line 40:
.getEventDao().getEventNotificationMethodsById(method_id));
Line 41: if (event_notification_methods.size() > 0) {
Line 42: // validate event
Line 43: List<EventMap> event_map =
DbFacade.getInstance().getEventDao().getEventMapByName(event_name);
why not re-factoring variables to standard java as well ???
Line 44: if (event_map.size() > 0) {
Line 45: String domain = getParameters().getDomain();
Line 46: // Validate user
Line 47: DbUser user =
DbFacade.getInstance().getDbUserDao().get(subscriberId);
--
To view, visit http://gerrit.ovirt.org/10053
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If79d19988555eefd7c94e5f8989a01910b3a41e9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
