Itamar Heim has posted comments on this change.
Change subject: core : implementing AddExternalEventCommand ...
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java
Line 25:
Line 26: @Override
Line 27: protected boolean canDoAction() {
Line 28: boolean result=true;
Line 29: if (getParameters().getEvent() == null ||
getParameters().getEvent().equals(OVIRT)){
getEvent would equal OVIRT?
Line 30:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN);
Line 31: result = false;
Line 32: }
Line 33: if (!result) {
Line 26: @Override
Line 27: protected boolean canDoAction() {
Line 28: boolean result=true;
Line 29: if (getParameters().getEvent() == null ||
getParameters().getEvent().equals(OVIRT)){
Line 30:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN);
I think you missed the intention of origin - it's either a free form string, or
a config. no point in having it if it can only be ovirt.
Line 31: result = false;
Line 32: }
Line 33: if (!result) {
Line 34: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
Line 29: if (event == null) {
Line 30:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND);
Line 31: result = false;
Line 32: }
Line 33: if (event.getOrigin().equalsIgnoreCase(OVIRT)) {
why do you care about origin for remove?
Line 34:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN);
Line 35: result = false;
Line 36: }
Line 37: if (!event.getseverity().equals(AuditLogSeverity.ALERT)) {
--
To view, visit http://gerrit.ovirt.org/10094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3468a3dd99616e2436caee19b42b9cf448adc005
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
