Ayal Baron has posted comments on this change.
Change subject: core: ImportVm: fix disk alias generation
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 127: private static String nullSafeGetVmName(VM vm) {
Line 128: return vm == null ? "" : vm.getVmName();
Line 129: }
Line 130:
Line 131: private static int nullSafeGetCount(VM vm) {
name here is not specific to disks? i.e. shouldn't it be nullSageGetDiskCount?
Line 132: return vm == null ? 1 : vm.getDiskMapCount() + 1;
Line 133: }
Line 134:
Line 135: /**
Line 128: return vm == null ? "" : vm.getVmName();
Line 129: }
Line 130:
Line 131: private static int nullSafeGetCount(VM vm) {
Line 132: return vm == null ? 1 : vm.getDiskMapCount() + 1;
what makes sure that this method cannot be called twice in a row (before
getDiskMapCount is updated)?
Line 133: }
Line 134:
Line 135: /**
Line 136: * Suggests an alias for a disk.
--
To view, visit http://gerrit.ovirt.org/9629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdd6525529d3d5e0c8ee2c86b418562929118207
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
