Maor Lipchuk has uploaded a new change for review. Change subject: core:StorageHelper clenups, Use formatter. ......................................................................
core:StorageHelper clenups, Use formatter. Use formatter in storage helper classes. Change-Id: I7c141cf02d7a98f3e40c6f62e87b05a65a6fb330 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 2 files changed, 25 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/10138/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java index ffdd14e..caf7912 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java @@ -35,7 +35,11 @@ @SuppressWarnings("unchecked") @Override - protected boolean runConnectionStorageToDomain(storage_domains storageDomain, Guid vdsId, int type, LUNs lun, Guid storagePoolId) { + protected boolean runConnectionStorageToDomain(storage_domains storageDomain, + Guid vdsId, + int type, + LUNs lun, + Guid storagePoolId) { boolean isSuccess = true; List<storage_server_connections> list = (lun == null) ? DbFacade.getInstance() @@ -223,7 +227,11 @@ @Override public boolean connectStorageToLunByVdsId(storage_domains storageDomain, Guid vdsId, LUNs lun, Guid storagePoolId) { - return runConnectionStorageToDomain(storageDomain, vdsId, VDSCommandType.ConnectStorageServer.getValue(), lun, storagePoolId); + return runConnectionStorageToDomain(storageDomain, + vdsId, + VDSCommandType.ConnectStorageServer.getValue(), + lun, + storagePoolId); } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java index a1f5d23..9ad602c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java @@ -46,7 +46,11 @@ protected abstract boolean runConnectionStorageToDomain(storage_domains storageDomain, Guid vdsId, int type); - protected boolean runConnectionStorageToDomain(storage_domains storageDomain, Guid vdsId, int type, LUNs lun, Guid storagePoolId) { + protected boolean runConnectionStorageToDomain(storage_domains storageDomain, + Guid vdsId, + int type, + LUNs lun, + Guid storagePoolId) { return true; } @@ -63,7 +67,11 @@ @Override public boolean connectStorageToLunByVdsId(storage_domains storageDomain, Guid vdsId, LUNs lun, Guid storagePoolId) { - return runConnectionStorageToDomain(storageDomain, vdsId, VdcActionType.ConnectStorageToVds.getValue(), lun, storagePoolId); + return runConnectionStorageToDomain(storageDomain, + vdsId, + VdcActionType.ConnectStorageToVds.getValue(), + lun, + storagePoolId); } @Override @@ -154,15 +162,14 @@ protected void printLog(Log logger, String connectionField, String errorCode) { String translatedError = getTranslatedStorageError(errorCode); logger.errorFormat( - "The connection with details {0} failed because of error code {1} and error message is: {2}", - connectionField, errorCode, Backend.getInstance().getVdsErrorsTranslator() - .TranslateErrorTextSingle(translatedError)); + "The connection with details {0} failed because of error code {1} and error message is: {2}", + connectionField, errorCode, Backend.getInstance().getVdsErrorsTranslator() + .TranslateErrorTextSingle(translatedError)); } /** - * Get translated error by error code ,if no enum for the error code (should not happened) , - * will set the error code instead. - * When no enum found for the error code, we should check it with the vdsm team. + * Get translated error by error code ,if no enum for the error code (should not happened) , will set the error code + * instead. When no enum found for the error code, we should check it with the vdsm team. * * @param errorCode * - The error code we want to translate. -- To view, visit http://gerrit.ovirt.org/10138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c141cf02d7a98f3e40c6f62e87b05a65a6fb330 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
