Maor Lipchuk has posted comments on this change.
Change subject: core: Use storage helper to fetch (related to BZ882825)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHelperBaseTest.java
Line 26:
Line 27: @Test
Line 28: public void getLunConnectionsForISCSI() {
Line 29: LUNs lun = new LUNs();
Line 30: ArrayList<storage_server_connections> connections = new
ArrayList<storage_server_connections>();
See my comment in the following comment
Line 31: connections.add(new storage_server_connections("Some LUN
connection",
Line 32: "id",
Line 33: "iqn",
Line 34: "password",
Line 44: "Username",
Line 45: "port",
Line 46: "portal"));
Line 47:
Line 48: lun.setLunConnections(connections);
I think it is implementation detail, I dislike proxy methods which only exist
because the API of the existing method is too long
Line 49: Map<StorageType, List<storage_server_connections>>
connectionsByType =
Line 50: StorageHelperBase.filterLUNsByStorageType(lun);
Line 51: assertTrue("Map of ISCSI storage connections should not be
empty.", !connectionsByType.isEmpty());
Line 52: assertEquals("Map of ISCSI storage connections should have
only one type of connections.",
--
To view, visit http://gerrit.ovirt.org/10141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida526dd9e08bc9881e65a529cb1b00aee0786af1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
