Michael Kublin has posted comments on this change.
Change subject: engine: if connect storage pool fails on version mismatch, do
reconstruct master
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 155: * if operation will wail on StoragePoolWrongMaster or
StoragePoolMasterNotFound errors
Line 156: * we will try to run reconstruct
Line 157: * @return
Line 158: */
Line 159: private boolean connectHostToPool() {
I think that it will be better to load the data during the event execution and
not before - - Agree.
now we have the events executed by order..but that data loading is done
separately before so it might be outdated till the event is executed and cause
additional reconstruct even though reconstruct already finished succesfully. -
we still don't have, because my code still not merged
Line 160: setStoragePool(null);
Line 161: final Guid masterDomainIdFromDb = getMasterDomainIdFromDb();
Line 162: final VDS vds = getVds();
Line 163: final storage_pool storagePool = getStoragePool();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java
Line 13: public ReconstructMasterParameters(Guid storagePoolId, Guid
storageDomainId, boolean isInactive) {
Line 14: super(storageDomainId, storagePoolId);
Line 15: setInactive(isInactive);
Line 16: }
Line 17:
No
Line 18: public ReconstructMasterParameters(Guid storagePoolId, Guid
storageDomainId, Guid vdsId, boolean isInactive) {
Line 19: super(storageDomainId, storagePoolId);
Line 20: setInactive(isInactive);
Line 21: setVdsId(vdsId);
--
To view, visit http://gerrit.ovirt.org/10103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d11c068399664daf85a6b03e67d25cd382707e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
