Liron Aravot has posted comments on this change.
Change subject: core: add clear message for live snapshot fail
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 265: // if live snapshot is not available, then if vm is up -
snapshot is not possible so it needs to be
Line 266: // checked if vm up or not
Line 267: // if live snapshot is enabled, there is no need to check if
vm is up since in any case snapshot is possible
Line 268: if (!isLiveSnapshotEnabled() && !ImagesHandler.isVmDown(vm)) {
Line 269: // if there is no live snapshot and the vm is up -
snapshot is not possible
please change here to: return failCanDoAction...
Line 270:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DATA_CENTER_VERSION_DOESNT_SUPPORT_LIVE_SNAPSHOT);
Line 271: return false;
Line 272: }
Line 273: return true;
--
To view, visit http://gerrit.ovirt.org/10171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
