Doron Fediuck has posted comments on this change.
Change subject: webamin: hide cpuPin section according to config values
......................................................................
Patch Set 1: (2 inline comments)
Inline.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 83: GlusterVolumeOptionGroupVirtValue,
Line 84: GlusterVolumeOptionOwnerUserVirtValue,
Line 85: GlusterVolumeOptionOwnerGroupVirtValue,
Line 86: CpuPinningEnabled,
Line 87: CpuPinMigrationEnabled,
Why would you have an empty entry?
Line 88: ;
Line 89:
Line 90: public static enum ConfigAuthType {
Line 91: Admin,
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 749: }
Line 750: }
Line 751: }
Line 752:
Line 753: private boolean isVmMigratable() {
That's ok, but why should we duplicate the logic?
We should have one logic, and if it exists in the business entity that's even
better.
Line 754: if
(Boolean.TRUE.equals(getModel().getRunVMOnSpecificHost().getEntity())
Line 755: ||
Boolean.FALSE.equals(getModel().getIsAutoAssign().getEntity())
Line 756: ||
Boolean.TRUE.equals(getModel().getDontMigrateVM().getEntity())) {
Line 757: return false;
--
To view, visit http://gerrit.ovirt.org/9664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
