Tomas Jelinek has uploaded a new change for review.

Change subject: userportal: NPE in OsTypeImage
......................................................................

userportal: NPE in OsTypeImage

The OsTypeImage creates the name of the default OS type
like: "otherOs" + nameUniquePart + IMAGE, where the IMAGE is "Image",
the nameUniquePart is "Large" or "Small".

Than takes this name and looks up the specific image from the
ApplicationResourcesWithLookup. The probelm was, that the otherOsLargeImage
was written with capital "O", which caused periodic NPE thrown on
FE.

Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1
Signed-off-by: Tomas Jelinek <[email protected]>
---
M 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/10209/1

diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
index db14cdf..292f32d 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
@@ -67,7 +67,7 @@
 
     // TODO remove the same resources from ApplicationResources and rename this
     @Source("images/os/Other.jpg")
-    ImageResource OtherOsSmallImage();
+    ImageResource otherOsSmallImage();
 
     @Source("images/os/OtherLinux.jpg")
     ImageResource OtherLinuxSmallImage();


--
To view, visit http://gerrit.ovirt.org/10209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to