Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: CellTable IE8 optimization ......................................................................
Patch Set 1: I'm starting to realize that onFocus/onBlur is mostly redundant for us, since all it does is apply special "keyboard selection" style to row/cells. AFAIK we don't visually distinguish between classic selection and keyboard selection. onFocus/onBlur relates to table widget gaining/losing focus, which isn't too big deal for us (onBlur removes "keyboard selection" style, onFocus adds it again). As for mouseover/mouseout events, this is the major cause of CellTable slowness in IE. For some reason, GWT developers decided to implement row highlight behavior by dynamically adding/removing styles based on mouseover/mouseout events. This just doesn't make sense to me, because CSS :hover pseudo-class is always better/faster than dynamic style manipulation. I'll submit new patch set with both improvements mentioned above. Everything should work and look the same as before. -- To view, visit http://gerrit.ovirt.org/10212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If69e21731ddad072405b68b6ea81d8ef814b22dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
